Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create organizer profile on add event. #358

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iiio2
Copy link
Member

@iiio2 iiio2 commented Mar 26, 2023

No description provided.

@iiio2 iiio2 requested a review from razbakov March 26, 2023 15:34
@iiio2 iiio2 self-assigned this Mar 26, 2023
components/TInput/TInputProfile.vue Outdated Show resolved Hide resolved
components/TInput/TInputProfile.vue Outdated Show resolved Hide resolved
@iiio2 iiio2 requested a review from razbakov March 28, 2023 15:55
<TButton
@click="
create({
username: inviteUsername,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with username extraction. Let's say this link will be provided https://facebook.com/profile.php?id=3234, which username will be set in this case?

@iiio2 iiio2 requested a review from razbakov May 27, 2023 12:46

export default {
name: 'TInputProfile',
inheritAttrs: false,

components: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components are auto imported

/>
<div>Username</div>
<TField
v-model="query"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

username is computed in inviteUsername variable

@@ -32,7 +32,7 @@ export default {
}),
watch: {
value(val) {
const extra = [...val, {}]
const extra = [...val, '']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check other pages where TInputArray is used, i think this change will break that component on other pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants