-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: convert text to venue #168
Open
amanuela97
wants to merge
8
commits into
beta
Choose a base branch
from
textToVenue
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* integration of prettier tailwindcss plugin * reformat codebase Co-authored-by: Aleksey Razbakov <[email protected]>
amanuela97
requested review from
harshbrahmxatriya,
larrycoal,
nelson2411 and
Stefanacef
February 16, 2022 17:58
razbakov
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it working?
amanuela97
force-pushed
the
textToVenue
branch
6 times, most recently
from
March 4, 2022 14:29
f3e695a
to
f4b47bc
Compare
fix: linting error
razbakov
force-pushed
the
beta
branch
2 times, most recently
from
February 13, 2024 20:19
b04c682
to
057d70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Developer I need a function
getVenueFromText(input): Venue
so that I can implement #143 and #101It should return existing venue from venues collection (find by place_id) or add new one.
Examples of input:
should output this object:
Return:
Closes #158
Demo: https://wedance-amanuela97.netlify.app/demo/venueFromText/