Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a TimePicker-Spinner #509

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Falke-Design
Copy link

  • Can used in combination with the wheel or alone
  • The spinner colors can be changed
  • Spinner not working with seconds or with selectable or disabled times
  • The sample is updated with the new functions

I needed a spinner for my App, so I implemented it into your code. Maybe you want to add it into your repo.

can used in combination with the wheel or alone
the spinner colors can be changed
spinner not working with seconds or with selectable or disabled times

 the sample is updated with the new functions
@wdullaer
Copy link
Owner

Thanks for taking the time to contribute!

I don't have a lot of time at the moment to go through this in detail.
Could you maybe provide a screenshot of the result.

If I am going to merge this, your version will need to support all the options the regular pickers support. It will lead to a lot of issues from confused people otherwise.

@kassim
Copy link

kassim commented Apr 29, 2019

@Falke-Design what's the status of this? I've come to the need of a spinner selector with the features of MaterialDateTimePicker so am quite interested

@Falke-Design
Copy link
Author

I have nothing done since then

@ScratchMyTail
Copy link

@wdullaer What's the status on this pull request? I would really loved to have this functionality added to the library.

@wdullaer
Copy link
Owner

This probably won't be merged.
The author hasn't shown any interest in continuing to work on this and incorporate any feedback.

I don't have the time, nor do I really want to increase the support surface of this library.

@Falke-Design
Copy link
Author

@vishal901 i resolved the conflicts, maybe you can take a look in the code again.
I have no time and no interessting to add the additional features what are requested from @wdullaer, so if he don't want to merge it without the features, it would maybe never merged into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants