Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrea's TicTacToe #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Andrea's TicTacToe #209

wants to merge 2 commits into from

Conversation

andicodetrf
Copy link

Deliverable Submission

Please describe your comfort and completeness levels before submitting.

Comfort Level (1-5): finished 1st version

Completeness Level (1-5): 5 for 1st version

How many hours did you spend on this assignment? 1.5 hours

What part did you spend the most time on? creating a grid in html and css-ing it

Does the assignment run without errors? think so

If the assignment has errors, what are they?

Describe one part of the code or choose one line you would improve upon.

What would you improve?

What did you think of this deliverable? Any other comments?

@andicodetrf
Copy link
Author

will work on 2nd version

@andicodetrf
Copy link
Author

Comfort Level (1-5): finished 2nd version; 2 out of 5 for CSS

Completeness Level (1-5): 1.5 for 2nd version

How many hours did you spend on this assignment? 1.5 hours

What part did you spend the most time on? controlling the CSS part

Does the assignment run without errors? functionality is the same as ver1. aesthetically, error on layout

If the assignment has errors, what are they? span size changes when player inputs X or O.

Describe one part of the code or choose one line you would improve upon. CSS part; not sure what am i doing just trial and error for span..

What would you improve? fix span size regardless if there is any text within. or perhaps i should've used div instead of span and display as inline.

What did you think of this deliverable? Any other comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant