-
Notifications
You must be signed in to change notification settings - Fork 49
Issue 24 invalid epub #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clach04
wants to merge
14
commits into
wcember:master
Choose a base branch
from
clach04:issue_24_invalid_epub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's mimetype, not "minetype", and the file should have no extension. See: https://www.w3.org/publishing/epub3/epub-ocf.html#sec-zip-container-mime
Fix found in wcember#13 branch missing :-( so manually applied diff.
Use own zip code to walk directory and place mimetype file first. Fix EPUBCheck v5.1.0 ERROR(PKG-006): Mimetype wrong location ERROR(PKG-006): My First Epub.epub//...../My%20First%20Epub.epub(-1,-1): Mimetype file entry is missing or is not the first file in the archive.
Use own zip code to walk directory and place mimetype file first. Fix EPUBCheck v5.1.0 ERROR(PKG-006): Mimetype wrong location ERROR(PKG-006): My First Epub.epub//...../My%20First%20Epub.epub(-1,-1): Mimetype file entry is missing or is not the first file in the archive.
Fix EPUBCheck v5.1.0 FATAL(RSC-016) had hr tag FATAL(RSC-016): ......epub/OEBPS/toc.html(15,5): Fatal Error while parsing file: The element type "hr" must be terminated by the matching end-tag "</hr>".
* Clarify epub version support - specifically epub2 / version 2 * TODO notes in relation to title support * implement title per chapter to ensure epub is valid - epubcheck ERROR(RSC-005) * correct uuid support * ensure correct unique id is declared ERROR(OPF-048) and ERROR(RSC-005) * various missing html/xhml tag fixes ERROR(HTM-004 * ISO/ANSI dates (date only at the moment) ERROR(OPF-054) * TODO note for dates, include timestamp * use valid xml id/names for chapters ERROR(HTM-004) * use consistent filenames for chapter that matches id Allows EPUBCheck v5.1.0 to run clean with simple html chapter content.
New test for html to xhtml without title to test default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE not ready for review. Many outstanding issues still remaining.
Posting for progress.