Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make syscheck file_limit configurable #603 #604

Open
wants to merge 1 commit into
base: 4.3
Choose a base branch
from

Conversation

Fabian1976
Copy link
Contributor

We sometimes reach the limit of files scanned. So it would be nice if it could be made configurable by merging this PR.

@vcerenu vcerenu self-assigned this Dec 5, 2022
@vcerenu
Copy link
Member

vcerenu commented Dec 6, 2022

Hello @Fabian1976

Thank you very much for your contribution!

The development is correct, but the option you add has to declare whether or if at the time of using the wazuh::manager class, so it fails if it is not declared at the time of installing.
The wazuh::manager should work without any parameter how it works at the moment, so the variable for the File Limit parameter should have a default value equal to the one it has today and also add the possibility of modifying. If you can give it a default value to continue using the installation script that we have in the documentation, we reduce it.

Thank you again for contributing to the project and I wait for your answer!

@Fabian1976
Copy link
Contributor Author

Sorry for the extremely late response (we made a fork and i forgot about this PR. I'm cleaning up old stories and found this one). I have set defaults in the PR, so i don't think i understand what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants