Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attributes in unused in select input #6725

Merged
merged 2 commits into from
May 30, 2024
Merged

Remove attributes in unused in select input #6725

merged 2 commits into from
May 30, 2024

Conversation

yenienserrano
Copy link
Member

Description

Remove attributes in unused in select input to remove console errors

Issues Resolved

Evidence

Screen.Recording.2024-05-29.at.10.18.26.PM.mov

Test

  1. Navigate to Dashboard management > App settings
  2. Check that these errors do not appear in the console

React does not recognize the isClearable prop on a DOM element.
React does not recognize the isDisabled prop on a DOM element.
React does not recognize the selectedOptions prop on a DOM element.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this May 29, 2024
@yenienserrano yenienserrano mentioned this pull request May 29, 2024
Closed
15 tasks
@yenienserrano yenienserrano linked an issue May 29, 2024 that may be closed by this pull request
Warnings and errors in console #6693
Closed
15 tasks
asteriscos
asteriscos approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-05-30 11-38

@lucianogorza lucianogorza self-requested a review May 30, 2024 14:52
lucianogorza
lucianogorza approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

@asteriscos asteriscos merged commit 33fddd7 into 4.9.0 May 30, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6693-React-does-not-recognize-the-x-prop-on-a-DOM-element branch May 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
3 participants
@yenienserrano @asteriscos @lucianogorza