Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change key prop in rule.mitre.id column render #6715

Merged
merged 3 commits into from
May 30, 2024
Merged

Change key prop in rule.mitre.id column render #6715

merged 3 commits into from
May 30, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 28, 2024 •
edited
Loading

Description

The index is added to the key in case it has the same key.

Issues Resolved

Evidence

Screen.Recording.2024-05-28.at.8.40.04.PM.mov

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano mentioned this pull request May 28, 2024
Closed
15 tasks
@chantal-kelm chantal-kelm self-requested a review May 29, 2024 16:53
chantal-kelm
chantal-kelm approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Grabacion.de.pantalla.2024-05-29.a.la.s.1.53.07.p.m.mov

@yenienserrano yenienserrano self-assigned this May 29, 2024
asteriscos
asteriscos approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-05-30 13-45

@asteriscos asteriscos merged commit 42ca330 into 4.9.0 May 30, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6693-mitre-attack-unique-key-prop branch May 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yenienserrano @asteriscos @chantal-kelm