Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove warning] euisuggestitem prop type error #6714

Merged
merged 4 commits into from
May 29, 2024
Merged

[Remove warning] euisuggestitem prop type error #6714

merged 4 commits into from
May 29, 2024

Conversation

yenienserrano
Copy link
Member

Description

Replace a EuiSuggestItem with the one already offered by opensearch oui

Issues Resolved

Evidence

Screen.Recording.2024-05-28.at.6.28.07.PM.mov

Test

Navigate to Endpoint summary

  • The error in the console should not be shown: EuiSuggestItem: prop type type.iconType is invalid
  • Suggestions should work as expected

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this May 28, 2024
@yenienserrano yenienserrano linked an issue May 28, 2024 that may be closed by this pull request
Warnings and errors in console #6693
Closed
15 tasks
@yenienserrano yenienserrano mentioned this pull request May 28, 2024
Closed
15 tasks
@asteriscos asteriscos self-requested a review May 28, 2024 17:20
asteriscos
asteriscos requested changes May 28, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🔴
This fix implies removing a custom component and using a native one. I would add a changelog entry.

asteriscos
asteriscos approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-05-28 19-38

@chantal-kelm chantal-kelm self-requested a review May 29, 2024 16:21
chantal-kelm
chantal-kelm approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Grabacion.de.pantalla.2024-05-29.a.la.s.1.24.42.p.m.mov

@asteriscos asteriscos merged commit 71199ab into 4.9.0 May 29, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6693-euisuggestitem-prop-type-error branch May 29, 2024 18:12
@JuanGarriuz JuanGarriuz mentioned this pull request Jun 21, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Jul 16, 2024
Closed
1 task
@Machi3mfl Machi3mfl mentioned this pull request Jul 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
3 participants
@yenienserrano @asteriscos @chantal-kelm