Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the incorrect use of a div tag as a child of a p tag #6701

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix the incorrect use of a div tag as a child of a p tag #6701

merged 2 commits into from
May 28, 2024

Conversation

JuanGarriuz
Copy link
Member

Description

This PR fixes the console warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

Issues Resolved

Evidence

Warning message:

image

Update:

image

Test

  • Go to Server management > Endpoints Summary
  • Click on an agent
  • Unpin the selected agent
  • This console error don't must be rendered

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz mentioned this pull request May 23, 2024
Closed
15 tasks
@JuanGarriuz JuanGarriuz linked an issue May 23, 2024 that may be closed by this pull request
Warnings and errors in console #6693
Closed
15 tasks
@JuanGarriuz JuanGarriuz self-assigned this May 23, 2024
asteriscos
asteriscos approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
image

yenienserrano
yenienserrano approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-05-27.at.8.20.42.PM.mov

@asteriscos asteriscos merged commit 5ddde24 into 4.9.0 May 28, 2024
1 check passed
@asteriscos asteriscos deleted the feat/6693-invalid-p-parent-of-a-div branch May 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
3 participants
@JuanGarriuz @asteriscos @yenienserrano