-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp #83
base: master
Are you sure you want to change the base?
Revamp #83
Conversation
Have you done any benchmarks? If it is faster than current code , it is very good |
The only thing that has really changed is the structure of the code, but the underlying methods that are performed are pretty much the same. All class instances are stored now throughout the app so that may help with some performance. You can also capture the SteamCommunity instance now and cache it to a file or whatever and load it up next execution so you don't have to constantly re-login. Also it made the code much more simplified, so no more passing around an instance of the steamcommunity class. Creating an instance is pretty much the same:
|
Looks good! I'll go through your changes, but in the meantime if anybody else would like to help test it, please leave your feedback below. |
Is there any update here? I can first test it next week. |
@ellisonpatterson You wrote that it's possible now to capture the steam instance and cache it. Which part would be cached? Or I should simply serialise and deserialise it at caching? |
@ghostika just serialize SteamCommunity::getInstance() and you cannot handle multiple bots currently but since everything is based off that instance, it would be pretty easy to adjust it for handling many at once :) |
I gotta document all the changes, but just something that is available for anyone to sink their teeth into.
Things Incorporated:
Full Inventory Parser
Network Class that can use proxies and multiple IPs/interfaces
Market Parsing
Chat Integration on both web and mobile
Profile Updating and commenting
Friend List management / invitations
Group management / invitations
Notification fetching
Trade Offer itemhover parsing
Retries for Trade Offers / Confirmations
Some stuff isn't complete, like the whole thing with captchas or something, but that's related to account creation so not a huge thing and should be easy to fix.