Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev feature 7 - Deprecating Backed Assets #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dev feature 7 - Deprecating Backed Assets #9

wants to merge 3 commits into from

Conversation

on-a-t-break
Copy link

  • Adds checks for asset vector to be empty during "mintasset"
  • Fully deprecates "backasset"
  • Removes "internal_back_asset" & other redacted functions

Question: Should "announcedepo" become deprecated as well with this change?

jona-wilmsmann
jona-wilmsmann reviewed Oct 12, 2024
View reviewed changes
Copy link

@jona-wilmsmann jona-wilmsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me (although I'd keep in the logbackasset action as mentioned).

I think announcedepo can remain, it keeps the internal atomicassets balance system intact (which won't be used for anything anymore, but it doesn't rellay hurt to keep it either).

include/atomicassets.hpp Outdated
@@ -233,12 +233,6 @@ CONTRACT atomicassets : public contract {
ATTRIBUTE_MAP new_data
);

ACTION logbackasset(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it probably makes sense to keep this in just so the new abi can still be used to deserialize old log actions

@on-a-t-break
Copy link
Author

on-a-t-break commented Oct 14, 2024 •
edited
Loading

Incorporated all comments above, ready for merging into CPU optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jona-wilmsmann jona-wilmsmann jona-wilmsmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@on-a-t-break @jona-wilmsmann