Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do/fix?
This PR improve PDF highlighting.
10h00
should be right below the18h00
, but it isn't. This is because I improved highlighting by giving priority to longer matches in fix: fix and improve PDF highlighting #313.The text box mapping logic manages text positions where text fragments are mapped recently. The positions are used to generate longer chunk of matches. But with the improvement, the mapping process is repeated. So, the logic tried to generate longer chunk based on the position information form the previous iteration. It made the wrong highlight location.
So, I fixed the logic to reset the position information after each iteration.
In the mapping, longer match between field text and text form PDF makes highlight more accurate. But in some PDF, its text content items may not be ordered by text order. It produces many small mappings instead of a long mapping. So, this is to reorder the text content items using the text order in HTML field.
How do you test/verify these changes?
Have you documented your changes (if necessary)?
Are there any breaking changes included in this pull request?