-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CODEOWNERS file #1551
Create CODEOWNERS file #1551
Conversation
A few comments: 1.) Can we add Maojian (Morgan88888888) to the list of WaterTAP members? He's already in the IDAES repo. 2.) Some of us had a discussion offline about how comprehensive the lists should be. Ultimately we landed on including any relevant names. This will help with allocating responsibilities when people are offboarding and also provides some insight into areas of the repo where we could potentially use more support (if there's only 1-2 names listed). It's also just easier to trim down a list of excess names rather than trying to dig for more names. We're open to feedback on this tho. |
@MarcusHolly When we did this for the IDAES side we decided to have a short list of names with the intent that these were the first points of contact. It was not expected that the code owners would fix everything that came up, but would rather know who would be able to fix the issue and help find the right person to do the job. |
Thanks for adding that context. Is there any inherent downside to including a more comprehensive list of names though? For what it's worth, the names are listed from most involved/knowledgeable to least involved/knowledgeable (from left to right). So I could easily trim down the lists if we want to stick to 1-3 names. |
The biggest issue is dilution of responsibility - if you get an email saying a certain thing needs to be fixed and it only has your name and one other person, you are much more likely to take ownership than if there is a longer list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: