Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS file #1551

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Create CODEOWNERS file #1551

merged 8 commits into from
Feb 14, 2025

Conversation

lbianchi-lbl
Copy link
Contributor

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jan 16, 2025
@ksbeattie ksbeattie self-requested a review January 16, 2025 21:40
@ksbeattie ksbeattie self-assigned this Jan 16, 2025
@MarcusHolly
Copy link
Contributor

MarcusHolly commented Jan 17, 2025

A few comments:

1.) Can we add Maojian (Morgan88888888) to the list of WaterTAP members? He's already in the IDAES repo.

2.) Some of us had a discussion offline about how comprehensive the lists should be. Ultimately we landed on including any relevant names. This will help with allocating responsibilities when people are offboarding and also provides some insight into areas of the repo where we could potentially use more support (if there's only 1-2 names listed). It's also just easier to trim down a list of excess names rather than trying to dig for more names. We're open to feedback on this tho.

@andrewlee94
Copy link
Collaborator

@MarcusHolly When we did this for the IDAES side we decided to have a short list of names with the intent that these were the first points of contact. It was not expected that the code owners would fix everything that came up, but would rather know who would be able to fix the issue and help find the right person to do the job.

@MarcusHolly
Copy link
Contributor

@MarcusHolly When we did this for the IDAES side we decided to have a short list of names with the intent that these were the first points of contact. It was not expected that the code owners would fix everything that came up, but would rather know who would be able to fix the issue and help find the right person to do the job.

Thanks for adding that context. Is there any inherent downside to including a more comprehensive list of names though? For what it's worth, the names are listed from most involved/knowledgeable to least involved/knowledgeable (from left to right). So I could easily trim down the lists if we want to stick to 1-3 names.

@andrewlee94
Copy link
Collaborator

The biggest issue is dilution of responsibility - if you get an email saying a certain thing needs to be fixed and it only has your name and one other person, you are much more likely to take ownership than if there is a longer list.

@ksbeattie ksbeattie marked this pull request as ready for review January 23, 2025 21:13
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit a79f8b4 into main Feb 14, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants