Code

MCAS w/generic crystallizer#1487

Code

Merged

adam-a-a merged 54 commits intowatertap-org:mainwatertap-org/watertap:mainfrom adam-a-a:mcas_generic_crystallizeradam-a-a/watertap:mcas_generic_crystallizerCopy head branch name to clipboardOct 31, 2024

+1,366-29

Commits

Commits on Jul 9, 2024

• paste Mayo's surrogate_crystallizer unit in raw form

  adam-a-a

  committed
  1feb735

  Copy full SHA for 1feb735

• start code cleanup in surrogate crystallizer, add vapor prop pack config option, rename class

  adam-a-a

  committed
  3c32230

  Copy full SHA for 3c32230

• git rid of self.vap_prop instances

  adam-a-a

  committed
  db52f1e

  Copy full SHA for db52f1e

Commits on Jul 23, 2024

• Merge branch 'main' into mcas_generic_crystallizer

  adam-a-a

  committed
  ba1893c

  Copy full SHA for ba1893c

Commits on Jul 30, 2024

• Merge branch 'main' into mcas_generic_crystallizer

  adam-a-a

  committed
  7d12510

  Copy full SHA for 7d12510

Commits on Aug 6, 2024

• paste in seawater relationship for enth_mass_phase

  adam-a-a

  committed
  6595daa

  Copy full SHA for 6595daa

• pass tests for enth_mass_phase implementation in MCAS

  adam-a-a

  committed
  b62cbb4

  Copy full SHA for b62cbb4

Commits on Aug 12, 2024

• check value of enthalpy in test

  adam-a-a

  committed
  e1c99a7

  Copy full SHA for e1c99a7

Commits on Aug 20, 2024

• bring in test code

  adam-a-a

  committed
  4563e7c

  Copy full SHA for 4563e7c

Commits on Sep 10, 2024

• get test crystallizer surrogate file to pass

  adam-a-a

  committed
  4424c83

  Copy full SHA for 4424c83

• only construct enthalpy params once

  adam-a-a

  committed
  a6b8159

  Copy full SHA for a6b8159

• blk

  adam-a-a

  committed
  2531bda

  Copy full SHA for 2531bda

• add surrogate files

  adam-a-a

  committed
  7d0eb12

  Copy full SHA for 7d0eb12

• clean up imports and other code

  adam-a-a

  committed
  41832da

  Copy full SHA for 41832da

• track costing file

  adam-a-a

  committed
  4ce6242

  Copy full SHA for 4ce6242

• bk

  adam-a-a

  committed
  6eafd1d

  Copy full SHA for 6eafd1d

• raise config error instead of string

  adam-a-a

  committed
  5fbd721

  Copy full SHA for 5fbd721

• remove unused imports

  adam-a-a

  committed
  9a7f99b

  Copy full SHA for 9a7f99b

Commits on Sep 11, 2024

• Merge branch 'main' into mcas_generic_crystallizer

  adam-a-a

  authored
  edecffc

  Copy full SHA for edecffc

Commits on Oct 24, 2024

• changed filename and started cleanup

  adam-a-a

  committed
  2f690da

  Copy full SHA for 2f690da

• make folder for crystallizer surrogate defaults to test; finish cleanup

  adam-a-a

  committed
  18cd73a

  Copy full SHA for 18cd73a

• Merge branch 'mcas_generic_crystallizer' of https://github.com/adam-a-a/watertap into mcas_generic_crystallizer

  adam-a-a

  committed
  a58201f

  Copy full SHA for a58201f

• Merge branch 'main' into mcas_generic_crystallizer

  adam-a-a

  authored
  86d4fb7

  Copy full SHA for 86d4fb7

• blk

  adam-a-a

  committed
  b07ace5

  Copy full SHA for b07ace5

• Merge branch 'mcas_generic_crystallizer' of https://github.com/adam-a-a/watertap into mcas_generic_crystallizer

  adam-a-a

  committed
  3831b5f

  Copy full SHA for 3831b5f

Commits on Oct 25, 2024

• add folder

  adam-a-a

  committed
  bcddc5f

  Copy full SHA for bcddc5f

• cleanup imports and copyright headers

  adam-a-a

  committed
  4bc170c

  Copy full SHA for 4bc170c

• fix file path

  adam-a-a

  committed
  dd7aac9

  Copy full SHA for dd7aac9

• updated some var names to make a bit more user friendly and closer to idaes naming; also described a config option that was unclear

  adam-a-a

  committed
  a039651

  Copy full SHA for a039651

• blk

  adam-a-a

  committed
  427c635

  Copy full SHA for 427c635

• delete erronous code in mcas during initialization of enthalpy

  adam-a-a

  committed
  4895335

  Copy full SHA for 4895335

• fix issue with file path?

  adam-a-a

  committed
  67e5b54

  Copy full SHA for 67e5b54

• blk

  adam-a-a

  committed
  5a1d053

  Copy full SHA for 5a1d053

Commits on Oct 28, 2024

• black

  adam-a-a

  committed
  2793edc

  Copy full SHA for 2793edc

• move surrogate defaults

  adam-a-a

  committed
  5cd9db1

  Copy full SHA for 5cd9db1

• refine test file

  adam-a-a

  committed
  d018429

  Copy full SHA for d018429

• add pressure_sat and add some scaling

  adam-a-a

  committed
  b22c817

  Copy full SHA for b22c817

• black

  adam-a-a

  committed
  1bd2454

  Copy full SHA for 1bd2454

• add to MCAS tech ref; revise subtlety in sw prop model tech ref

  adam-a-a

  committed
  e2d37e8

  Copy full SHA for e2d37e8

• revise docs

  adam-a-a

  committed
  7a945c7

  Copy full SHA for 7a945c7

• fix rst

  adam-a-a

  committed
  11ef9d4

  Copy full SHA for 11ef9d4

• adjust th equation in rst

  adam-a-a

  committed
  21fef31

  Copy full SHA for 21fef31

• remove units inclusion for D

  adam-a-a

  committed
  060766b

  Copy full SHA for 060766b

• fix fraction

  adam-a-a

  committed
  85252da

  Copy full SHA for 85252da

• fix path issue

  adam-a-a

  committed
  788bbef

  Copy full SHA for 788bbef

• blk

  adam-a-a

  committed
  1cacd7d

  Copy full SHA for 1cacd7d

• fix relatiosnhip

  adam-a-a

  committed
  6d29750

  Copy full SHA for 6d29750

Commits on Oct 29, 2024

• try to fix path issues now having created init files

  adam-a-a

  committed
  275acf7

  Copy full SHA for 275acf7

• revise doc

  adam-a-a

  committed
  fc1a1dc

  Copy full SHA for fc1a1dc

• tinker with docs

  adam-a-a

  committed
  ac847b4

  Copy full SHA for ac847b4

• cleanup

  adam-a-a

  committed
  71b6e27

  Copy full SHA for 71b6e27

• add init files!

  adam-a-a

  committed
  df3f8b2

  Copy full SHA for df3f8b2

• regression tests for enth flow and pressure sat

  adam-a-a

  committed
  55643c9

  Copy full SHA for 55643c9

Commits on Oct 31, 2024

• Merge branch 'main' into mcas_generic_crystallizer

  OOAmusat

  authored
  168c9fc

  Copy full SHA for 168c9fc