-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV-driven variable exports #1232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 94.27% 94.27% -0.01%
==========================================
Files 357 357
Lines 35918 36011 +93
==========================================
+ Hits 33863 33950 +87
- Misses 2055 2061 +6 ☔ View full report in Codecov by Sentry. |
MichaelPesce
approved these changes
Dec 6, 2023
bknueven
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One method is completely uncovered.
bknueven
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Allow variable exports to be listed in a CSV file instead of (or in addition to) Python API calls.
This is a more compact way to export a lot of variables.
Does not alter or invalidate the existing Python API export method.
Changes proposed in this PR:
from_csv()
andto_csv()
from_csv()
to the how-to on the API. Streamlined the page too.importlib-resources
for Python < 3.11 support for the features that "find" the CSV datafiles in the package directoryLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: