Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid sub-directories should direct to 404 #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarahkwak79
Copy link

[CLICKUP TICKET LINK] (https://app.clickup.com/t/20e3n9z)

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Invalid sub-sub-directories on the main website should redirect to the 404 page, which is now fixed which previously was not directing to 404.

  • added this.generatePageMap({
    path: '/sub-directories/:id',
    MainComponent: ,
    }), for all sub-directories in the main router in App.tsx

Type Of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested if invalid sub-directories got redirected to 404

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation/READ-ME/UMLS (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for waterloop ready!

Name Link
🔨 Latest commit 340f3be
🔍 Latest deploy log https://app.netlify.com/sites/waterloop/deploys/656b68363872da00082e7e3a
😎 Deploy Preview https://deploy-preview-168--waterloop.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant