Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Typescript import errors, Fixes #23 #24

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

brandonfcohen1
Copy link
Contributor

Thank you for submitting a pull request!

Description

Added types to export in package.json

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No lint errors after pnpm lint
  • Make sure all the exsiting features working well

Refer to CONTRIBUTING.MD for more details.

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 37555c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@watergis/maplibre-gl-legend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for maplibre-gl-legend ready!

Name Link
🔨 Latest commit 37555c9
🔍 Latest deploy log https://app.netlify.com/sites/maplibre-gl-legend/deploys/65fc30c81267b200088a7abf
😎 Deploy Preview https://deploy-preview-24--maplibre-gl-legend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JinIgarashi
Copy link
Member

@brandonfcohen1 Thank you for PR. Could you also add a changeset file to bump a patch version? Then I can merge it

@brandonfcohen1
Copy link
Contributor Author

@brandonfcohen1 Thank you for PR. Could you also add a changeset file to bump a patch version? Then I can merge it

Hey @JinIgarashi - added a changeset per the instructions in the readme. Let me know if I didn't do that correctly.

@JinIgarashi JinIgarashi merged commit aca1d0b into watergis:main Mar 21, 2024
5 checks passed
@JinIgarashi
Copy link
Member

@brandonfcohen1 thanks! I released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants