add revert condition for puzzle names

waterfall-mkt · Nov 3, 2023 · 1da8246 · 1da8246
1 parent 1df24ac
commit 1da8246
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Curta.sol b/src/Curta.sol
@@ -116,6 +116,9 @@ contract Curta is ICurta, FlagsERC721, Owned {
         // Revert if the puzzle does not exist.
         if (address(puzzle) == address(0)) revert PuzzleDoesNotExist(_puzzleId);
 
+        // Revert if puzzle name is an empty string or not implemented.
+        if (bytes(puzzle.name()).length == 0) revert PuzzleNotNamed(_puzzleId);
+
         // Revert if submissions are closed.
         uint40 firstSolveTimestamp = puzzleData.firstSolveTimestamp;
         uint40 solveTimestamp = uint40(block.timestamp);

diff --git a/src/interfaces/ICurta.sol b/src/interfaces/ICurta.sol
@@ -40,6 +40,10 @@ interface ICurta {
     /// @param _puzzleId The ID of a puzzle.
     error PuzzleDoesNotExist(uint32 _puzzleId);
 
+    /// @notice Emitted when a puzzle has a zero-length name.
+    /// @param _puzzleId The ID of a puzzle.
+    error PuzzleNotNamed(uint32 _puzzleId);
+
     /// @notice Emitted when the puzzle was not the one that went longest
     /// unsolved.
     /// @param _puzzleId The ID of a puzzle.