Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinetime: wasp-reloader-factory - update factory_image.h to use new Infinitime bootloader 1.0.1 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GaryM0101
Copy link
Contributor

The wasp reloader_factory.zip that flashes the InfiniTime bootloader v 1.0.1 was successfully tested on the Pinetime with the new BY25Q32 memory chip. We also tested it on the original SPI chip on the older Pinetime devices.

https://github.com/wasp-os/wasp-os/issues/519

We updated the factory_image.h so that the reloader_factory.zip can revert back to the pinetime-mcuboot-recovery-image and flash the latest Infinitime firmware for all Pinetime devices.

daniel-thompson and others added 2 commits February 2, 2025 09:05
Signed-off-by: Daniel Thompson <[email protected]>
Signed-off-by: GaryM0101 <[email protected]>
Signed-off-by: GaryM0101 <[email protected]>

updated factory_image.h ready for review.

Signed-off-by: GaryM0101 <[email protected]>
@GaryM0101 GaryM0101 force-pushed the update-reloader-factory branch from 094d7b2 to c877709 Compare February 2, 2025 17:11
@daniel-thompson
Copy link
Collaborator

Thanks for the PR. Given the importance of the fix I decided to tidy it up rather than send you a code review.

Basically that only really meant tidying up my own 2021 commit (not sure how that ended up with your sign-off but git diff says it is the same as the original so I dropped that). The other thing I did was significantly improve the commit description. In generally I think it is better to describe the commit in the git commit description rather than the github pull request (I mostly just copied the info you put in there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants