-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple rosetta #1559
Apple rosetta #1559
Conversation
Awesome work @kristian240! Could you just please rebase this to |
786ab42
to
c54909a
Compare
@matijaSos all done! |
Ping @matijaSos |
I come a bit late to the party, but we already had a PR for Rosetta, I just remembered, it however never got merged although it was almost there: #1431 . Should we combine these two and get the best out of both? Anything to salvage from that one @kristian240 ? |
If my interpretation is accurate, the two PRs have different domains. The one from @Zeko369 has more in-depth explanations while this PR makes sure that the majority do not need to go to Discord to find out that Rosetta is needed. Does this make sense? If that is true, both PRs should be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for just throwing in that other PR, I was a bit on the go and didn't properly study it. What you said makes sense!
So this is looking good and is a welcome addition, I just had a couple of suggestions to consider before we merge:
Let's put this into
:::note Something Unclear?
TEXT HERE
:::
to have it be in a nice "NOTE" box!
Also, some ideas for the wording:
- Add
(arm64)
after Apple Silicon? Or not? - I would avoid "you might" here and reword it to "Encountering 'Bad CPU type in executable' on a device ... ?".
- I would maybe explain a bit why installing Rosetta is an issue -> That MacOS wasp binary is not currently pre-built for arm64 (Apple Silicon) but for x86 and that to get it running they can install Rosetta, which runs x86 stuff on arm64.
These are just suggestions, I am 100% sure in them, so do what you think makes sense and pls argument why not if it doesn't make sense.
Oh and checking if Rosetta is installed @kristian240 -> that is a cool idea! |
@Martinsos i changed the copy and place this in a NOTE box. Checkout the ss below. |
@matijaSos Take a look at wasp-lang/get-wasp#7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristian240 nice, here is last round of suggestions from my side!
|
||
Given that the wasp binary is built for x86 and not for arm64 (Apple Silicon), you'll need to install [Rosetta on your Mac](https://support.apple.com/en-us/HT211861). Rosetta is a translation process that enables users to run applications designed for x86 on arm64 (Apple Silicon). To install Rosetta, run the following command in your terminal: `softwareupdate --install-rosetta`. Once Rosetta is installed, you should be able to run Wasp without any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the wasp binary is built for x86 and not for arm64 (Apple Silicon), you'll need to install [Rosetta on your Mac](https://support.apple.com/en-us/HT211861). Rosetta is a translation process that enables users to run applications designed for x86 on arm64 (Apple Silicon). To install Rosetta, run the following command in your terminal: `softwareupdate --install-rosetta`. Once Rosetta is installed, you should be able to run Wasp without any issues. | |
Given that the wasp binary is built for x86 and not for arm64 (Apple Silicon), you'll need to install [Rosetta on your Mac](https://support.apple.com/en-us/HT211861) if you are using a Mac with Mx (M1, M2, ...) chip. Rosetta is a translation process that enables users to run applications designed for x86 on arm64 (Apple Silicon). To install Rosetta, run the following command in your terminal: `softwareupdate --install-rosetta`. Once Rosetta is installed, you should be able to run Wasp without any issues! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Martin Šošić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that's it! Thanks, merging!
Congrats @kristian240 on your first commit and becoming a contributor! :) Thanks for your patience. |
Description
As agreed in Discord I added a note in docs about MacOS Rosetta.
The next step is to detect the Apple SIlicon, check if the Rosetta is installed, and prompt the user to install it if needed.
Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following: