Skip to content

test: Add more tests of calls to functions without results #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Nov 16, 2020

Extracted from #642.

@chfast chfast requested review from gumb0 and axic November 16, 2020 16:39
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #641 (7be9a4f) into master (1ab75c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          69       69           
  Lines        9633     9658   +25     
=======================================
+ Hits         9476     9501   +25     
  Misses        157      157           

@chfast
Copy link
Collaborator Author

chfast commented Nov 17, 2020

Addressing @axic comment: I don't know if this is covered by the spectests, but this is motivated by "future Fizzy-specific implementation edge case". I don't this this is something that must be in the spectests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants