Fix typos #800

szepeviktor · 2025-01-15T20:38:24Z

Feature or Problem

Found few misspellings.

@CazJT Please consider using https://github.com/crate-ci/typos
and a language tool like DeepL Write.

netlify · 2025-01-15T20:38:43Z

✅ Deploy Preview for dreamy-golick-5f201e ready!

Name	Link
🔨 Latest commit	`39a4089`
🔍 Latest deploy log	https://app.netlify.com/sites/dreamy-golick-5f201e/deploys/67898ebc70608e0008cfbf29
😎 Deploy Preview	https://deploy-preview-800--dreamy-golick-5f201e.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

community/2023-09-20-community-meeting.mdx

markkovari · 2025-01-15T20:44:35Z

Ollala @szepeviktor what a small world we live in. 🤔

community/2024-02-21-community-meeting.mdx

community/2024-10-16-community-meeting.mdx

ericgregory · 2025-01-15T20:52:25Z

versioned_docs/version-0.82/reference/cloud-event-list.md

@@ -41,4 +41,4 @@ The following events are emitted on a special topic, `wasmbus.rpcevt.{lattice-id
 | Type                  | Fields                                                                                                                                                         | Description                 |
 | :-------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | :-------------------------- |
 | `invocation_failed`   | **`source`** (`public_key`, `contract_id`, `link_name`)<br/> **`dest`** (`public_key`, `contract_id`, `link_name`) <br/>`operation`<br/> `bytes` (payload len) | An RPC failure notification |
-| `invocation_suceeded` | _Same as above_                                                                                                                                                | An RPC success notification |


Since this spelling error is part of the cloud event list, it shouldn't actually be corrected. (Mostly for archival purposes since this is on an old version.)

ericgregory · 2025-01-15T20:56:29Z

versioned_docs/version-0.82/reference/wasi/incoming-http.md

@@ -105,7 +105,7 @@ corresponding to a clock tick.</p>
 </ul>
 <h4><a name="subscribe_instant"><code>subscribe-instant: func</code></a></h4>
 <p>Create a <a href="#pollable"><code>pollable</code></a> which will resolve once the specified instant
-occured.</p>


The spelling errors on this page derive from (a past version of) an upstream WIT document. They shouldn't be changed because it introduces drift from the upstream. (Not that consequential in this case because it's an old version of the WIT in an older version of the docs, but as a matter of precedent.)

ericgregory · 2025-01-15T20:57:03Z

versioned_docs/version-0.82/reference/wasi/interfaces.md

@@ -326,7 +326,7 @@ and stream is ready for writing again.</p>
 </ul>
 <h4><a name="method_output_stream.subscribe"><code>[method]output-stream.subscribe: func</code></a></h4>
 <p>Create a <a href="#pollable"><code>pollable</code></a> which will resolve once the output-stream
-is ready for more writing, or an error has occured. When this


The spelling errors on this page derive from (a past version of) an upstream WIT document. They shouldn't be changed because it introduces drift from the upstream. (Not that consequential in this case because it's an old version of the WIT in an older version of the docs, but as a matter of precedent.)

Reverted

versioned_docs/version-0.82/reference/wasi/incoming-http.md

versioned_docs/version-0.82/reference/wasi/interfaces.md

ericgregory · 2025-01-15T21:06:40Z

docs/reference/wasi/wrpc-interfaces.md

@@ -633,7 +633,7 @@ and stream is ready for writing again.</p>
 </ul>
 <h4><a id="method_output_stream_subscribe"></a><code>[method]output-stream.subscribe: func</code></h4>
 <p>Create a <a href="#pollable"><code>pollable</code></a> which will resolve once the output-stream
-is ready for more writing, or an error has occured. When this


The spelling errors on this page derive from an upstream WIT document. They shouldn't be changed because it introduces drift from the upstream.

ericgregory · 2025-01-15T21:06:53Z

docs/reference/wasi/interfaces.md

@@ -333,7 +333,7 @@ and stream is ready for writing again.</p>
 </ul>
 <h4><a id="method_output_stream_subscribe"></a><code>[method]output-stream.subscribe: func</code></h4>
 <p>Create a <a href="#pollable"><code>pollable</code></a> which will resolve once the output-stream
-is ready for more writing, or an error has occured. When this


The spelling errors on this page derive from an upstream WIT document. They shouldn't be changed because it introduces drift from the upstream.

ericgregory · 2025-01-15T21:07:20Z

docs/reference/wasi/incoming-http.md

@@ -105,7 +105,7 @@ corresponding to a clock tick.</p>
 </ul>
 <h4><a id="subscribe_instant"></a><code>subscribe-instant: func</code></h4>
 <p>Create a <a href="#pollable"><code>pollable</code></a> which will resolve once the specified instant
-occured.</p>


The spelling errors on this page derive from an upstream WIT document. They shouldn't be changed because it introduces drift from the upstream.

All three reverted.

docs/reference/wasi/incoming-http.md

docs/reference/wasi/interfaces.md

docs/reference/wasi/wrpc-interfaces.md

ericgregory · 2025-01-15T21:08:30Z

docs/reference/cloud-event-list.mdx

-| `invocation_suceeded` | An RPC success notification |
+| Type                   | Description                 |
+| :--------------------- | :-------------------------- |
+| `invocation_failed`    | An RPC failure notification |


This should be checked against the cloud events.

I do not know how to do that.

This is all I've found.
https://github.com/search?q=repo%3AwasmCloud%2Fwasmcloud-otp%20invocation_succeeded&type=code

No worries, I'll validate!

ericgregory · 2025-01-15T21:10:45Z

docs/cli/wash.mdx

@@ -1426,7 +1426,7 @@ Generate a wasmCloud component project

 ###### **Options:**

- `--git <GIT>` — Github repository url. Requires 'git' to be installed in PATH


This page is derived from wash CLI help -- all corrections for this page should go to the wash CLI in the wasmCloud monorepo: https://github.com/wasmCloud/wasmCloud/

In the gitattributes file you can mark these files as generated.
https://github.com/github-linguist/linguist/blob/main/docs/overrides.md#summary

ericgregory · 2025-01-15T21:30:37Z

@szepeviktor Thanks for the corrections and the quick responses. There are years of accumulated typos here from lots of folks! We'll need to make sure we're not inadvertently introducing drift from some of the upstream documents we use to generate certain pages (per my comments), and it'll be helpful to open issues on those errors in the relevant sources (for the wash CLI in the wasmCloud/wasmCloud repo, for example).

For the DCO check to pass, you can amend the commits with the --signoff option and push again.

In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes: git push --force-with-lease origin typos

Thanks again!

szepeviktor · 2025-01-15T21:39:25Z

Now DCO check shows a ✔️

szepeviktor · 2025-01-15T21:45:49Z

wasmCloud source code has ~500 typos.
https://github.com/crate-ci/typos 👈🏻

Signed-off-by: Viktor Szépe <[email protected]>

Co-authored-by: Eric Gregory <[email protected]> Signed-off-by: Viktor Szépe <[email protected]>

Signed-off-by: Viktor Szépe <[email protected]>

szepeviktor requested a review from a team as a code owner January 15, 2025 20:38

ericgregory reviewed Jan 15, 2025

View reviewed changes

community/2023-09-20-community-meeting.mdx Outdated Show resolved Hide resolved

ericgregory reviewed Jan 15, 2025

View reviewed changes

community/2024-02-21-community-meeting.mdx Outdated Show resolved Hide resolved

ericgregory reviewed Jan 15, 2025

View reviewed changes

community/2024-10-16-community-meeting.mdx Outdated Show resolved Hide resolved

ericgregory reviewed Jan 15, 2025

View reviewed changes

szepeviktor force-pushed the typos branch from e1dd232 to 84a5a42 Compare January 15, 2025 21:38

ericgregory approved these changes Jan 15, 2025

View reviewed changes

lachieh enabled auto-merge (rebase) January 16, 2025 22:51

auto-merge was automatically disabled January 16, 2025 22:53
Rebase failed

szepeviktor and others added 9 commits January 16, 2025 17:56

Fix typos

7fa2a60

Signed-off-by: Viktor Szépe <[email protected]>

Revert false positived and fix indentations

209d861

Signed-off-by: Viktor Szépe <[email protected]>

Update community/2023-09-20-community-meeting.mdx

d320704

Co-authored-by: Eric Gregory <[email protected]> Signed-off-by: Viktor Szépe <[email protected]>

Update community/2024-02-21-community-meeting.mdx

86e5124

Co-authored-by: Eric Gregory <[email protected]> Signed-off-by: Viktor Szépe <[email protected]>

Update community/2024-10-16-community-meeting.mdx

87763cb

Co-authored-by: Eric Gregory <[email protected]> Signed-off-by: Viktor Szépe <[email protected]>

Revert old cloud-event-list

6127a38

Signed-off-by: Viktor Szépe <[email protected]>

Revert typos from upstream

fcc41d1

Signed-off-by: Viktor Szépe <[email protected]>

Revert

a30f85c

Signed-off-by: Viktor Szépe <[email protected]>

Revert CLI docs

39a4089

Signed-off-by: Viktor Szépe <[email protected]>

lachieh force-pushed the typos branch from e619985 to 39a4089 Compare January 16, 2025 22:56

lachieh enabled auto-merge (rebase) January 16, 2025 22:57

lachieh merged commit 917d26d into wasmCloud:main Jan 16, 2025
4 of 5 checks passed

szepeviktor deleted the typos branch January 16, 2025 22:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos #800

Fix typos #800

szepeviktor commented Jan 15, 2025

netlify bot commented Jan 15, 2025 •

edited

Loading

markkovari commented Jan 15, 2025

ericgregory Jan 15, 2025

szepeviktor Jan 15, 2025

ericgregory Jan 15, 2025

ericgregory Jan 15, 2025

szepeviktor Jan 15, 2025

ericgregory Jan 15, 2025

ericgregory Jan 15, 2025

ericgregory Jan 15, 2025

szepeviktor Jan 15, 2025

ericgregory Jan 15, 2025

szepeviktor Jan 15, 2025

szepeviktor Jan 15, 2025

ericgregory Jan 15, 2025

ericgregory Jan 15, 2025 •

edited

Loading

szepeviktor Jan 15, 2025

szepeviktor Jan 15, 2025

ericgregory commented Jan 15, 2025 •

edited

Loading

szepeviktor commented Jan 15, 2025

szepeviktor commented Jan 15, 2025 •

edited

Loading

		@@ -1426,7 +1426,7 @@ Generate a wasmCloud component project

		###### Options:

		- `--git <GIT>` — Github repository url. Requires 'git' to be installed in PATH

Fix typos #800

Fix typos #800

Conversation

szepeviktor commented Jan 15, 2025

Feature or Problem

netlify bot commented Jan 15, 2025 • edited Loading

✅ Deploy Preview for dreamy-golick-5f201e ready!

markkovari commented Jan 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericgregory Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericgregory commented Jan 15, 2025 • edited Loading

szepeviktor commented Jan 15, 2025

szepeviktor commented Jan 15, 2025 • edited Loading

netlify bot commented Jan 15, 2025 •

edited

Loading

ericgregory Jan 15, 2025 •

edited

Loading

ericgregory commented Jan 15, 2025 •

edited

Loading

szepeviktor commented Jan 15, 2025 •

edited

Loading