Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

update wasmbus-rpc, interface-sqldb, +example/unions #130

Merged
merged 12 commits into from
Mar 9, 2022

Conversation

stevelr
Copy link
Contributor

@stevelr stevelr commented Feb 9, 2022

Signed-off-by: stevelr [email protected]

Copy link
Member

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way we can make this work without using CBOR? It feels like this is going to be a potentially confusing situation when someone goes to utilize unions in their smithy files and then realizes they can't get that functionality with message pack.

@stevelr
Copy link
Contributor Author

stevelr commented Feb 22, 2022

I hear this. On first pass, I didn't see any easy way to support msgpack with this, but I have a couple ideas to check out.

@stevelr stevelr changed the title add example for unions update wasmbus-rpc, interface-sqldb, +example/unions Mar 1, 2022
@stevelr
Copy link
Contributor Author

stevelr commented Mar 1, 2022

merged multiple PRs - wasmbus-rpc update, interface-sqldb update (which impacted petclinic), and unions

@stevelr
Copy link
Contributor Author

stevelr commented Mar 7, 2022

I haven't merge this yet because all of petclinic isn't working. Needs more debugging to figure out why.

@brooksmtownsend
Copy link
Member

@stevelr make sure to do a rebase, it's possible that there's some missing logic between petclinic in main and in this PR

@brooksmtownsend
Copy link
Member

@stevelr did a rebase so you'll have to re-pull down code. I just wanted to ensure that everything was up-to-date.

The error in petclinic was caused by wasmCloud/wasmcloud-otp#361, simply deleting and redefining the httpserver linkdef fixed the issue so I fixed the ordering in the startup script. I also added some fake data so that users don't have to go in through the psql interface and add a vet and pet type

@brooksmtownsend brooksmtownsend merged commit f874c74 into main Mar 9, 2022
@brooksmtownsend brooksmtownsend deleted the feat/unions branch March 21, 2022 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants