-
Notifications
You must be signed in to change notification settings - Fork 42
update wasmbus-rpc, interface-sqldb, +example/unions #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way we can make this work without using CBOR? It feels like this is going to be a potentially confusing situation when someone goes to utilize unions in their smithy files and then realizes they can't get that functionality with message pack.
I hear this. On first pass, I didn't see any easy way to support msgpack with this, but I have a couple ideas to check out. |
merged multiple PRs - wasmbus-rpc update, interface-sqldb update (which impacted petclinic), and unions |
I haven't merge this yet because all of petclinic isn't working. Needs more debugging to figure out why. |
@stevelr make sure to do a rebase, it's possible that there's some missing logic between petclinic in main and in this PR |
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
a47bee3
to
78b5953
Compare
@stevelr did a rebase so you'll have to re-pull down code. I just wanted to ensure that everything was up-to-date. The error in petclinic was caused by wasmCloud/wasmcloud-otp#361, simply deleting and redefining the httpserver linkdef fixed the issue so I fixed the ordering in the startup script. I also added some fake data so that users don't have to go in through the |
Signed-off-by: stevelr [email protected]