-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README #30 #31
base: master
Are you sure you want to change the base?
Conversation
### `wasm-pack` | ||
|
||
We expect `wasm-pack` to be in your `$PATH`. See [installation here](https://github.com/rustwasm/wasm-pack/blob/master/docs/src/setup.md#installing-wasm-pack). | ||
|
||
### `wasm-bindgen-cli` | ||
|
||
`wasm-bindgen` is a build requirement for `wasm-pack` and a dependency of `wasm-bindgen-cli`. To verify installation, run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But wont wasm-pack
installs this automatically from v0.5
### `wasm-pack` | ||
|
||
We expect `wasm-pack` to be in your `$PATH`. See [installation here](https://github.com/rustwasm/wasm-pack/blob/master/docs/src/setup.md#installing-wasm-pack). | ||
|
||
### `wasm-bindgen-cli` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the >= 0.5.0 versions of wasm-pack will automatically install the wasm-bindgen CLI for you (and the right version!) if necessary, so it shouldn't be a prerequisite to already have it installed anymore.
Just sent #36 too since we generally don't want to encourage -m no-install
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean, I ran into issue #30 with 0.5.1 of wasm-pack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was because no-install
mode was used, which forces wasm-pack into not downloading the w32-u-u target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There have been commits since then that removed the use of no-install, btw.
Can we get this merged? |
The |
These updates should help others get started.