Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ResultSet to only add new records to list if they don't already exist #304

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update ResultSet to only add new records to list if they don't already exist #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/authz/query/resultset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ func (rs *ResultSet) Add(objectType string, objectId string, warrant warrant.War
next: nil,
}

if existingRes, exists := rs.m[key(objectType, objectId)]; !exists || (existingRes.IsImplicit && !isImplicit) {
existingRes, exists := rs.m[key(objectType, objectId)]
if !exists {
// Add warrant to list
if rs.head == nil {
rs.head = newNode
Expand All @@ -67,7 +68,9 @@ func (rs *ResultSet) Add(objectType string, objectId string, warrant warrant.War
}

rs.tail = newNode
}

if !exists || (existingRes.IsImplicit && !isImplicit) {
// Add result node to map for O(1) lookups
rs.m[key(objectType, objectId)] = newNode
}
Expand Down
Loading