Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about DNS and StatefulSet #142

Merged
merged 4 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/warpstream-agent/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.13.58] - 2024-11-29

### Added

- Add clarifying comment in values.yaml

## [0.13.57] - 2024-11-25

### Added
Expand Down
2 changes: 1 addition & 1 deletion charts/warpstream-agent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: warpstream-agent
description: WarpStream Agent for Kubernetes.
type: application
version: 0.13.57
version: 0.13.58
appVersion: v602
icon: https://avatars.githubusercontent.com/u/132156278
home: https://docs.warpstream.com/warpstream/
Expand Down
12 changes: 11 additions & 1 deletion charts/warpstream-agent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,17 @@ fullnameOverride: ""
# Ignored if auto-scaling is enabled (which it is by default).
replicas: 3

# Only use StatefulSet when TLS is needed for an easier time managing certificates due to stable hostnames
# Only use StatefulSet when TLS is needed for an easier time managing certificates due to stable hostnames.
#
# *Note* that if you switch to using StatefulSet you should stop using WarpStream's convenience bootstrap
# URL in your Kafka clients, and switch to the Kubernetes service name instead. The reason for this is that
# when you switch to StatefulSet, the Agents will begin advertising their stable pod names in the Kafka
# protocol as their hostname, instead of their internal IP addresses. When this happens, WarpStream's DNS
# server will start returning CNAME's for the convience bootstrap URL for each Agent, but your application
# may not be able to resolve the CNAMEs due to limitations in things like CoreDNS.
#
# In general, we always recommend using the Kubernetes service name as the bootstrap URL for your clients
# when the Agents are deployed in Kubernetes to avoid issues like this.
deploymentKind: Deployment # or StatefulSet

# Only used in Deployments
Expand Down