Use the Tauri implementation of the DPI-change fix #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarl005
commented
Feb 14, 2025
| @@ -26,6 +27,9 @@ use windows_sys::Win32::UI::WindowsAndMessaging::{ | |||
|
|
|||
| use crate::window::CursorIcon; | |||
|
|
|||
| pub static WIN_VERSION: LazyLock<windows_version::OsVersion> = | |||
| LazyLock::new(windows_version::OsVersion::current); | |||
|
|
|||
There was a problem hiding this comment.
vorporeal
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt at #8. Instead of deleting that check altogether, it is guarded by a Windows version check. Tauri noticed in tauri-apps/tao#1056 that this is still necessary in Windows 10. In this commit i've reverted my fix and applied theirs on top.
It's a little easier to see using this semantic diff tool that they just wrapped a big block of code in an if-else.
Using that same tool to visualize this diff: https://app.semanticdiff.com/gh/warpdotdev/winit/pull/10/changes#src/platform_impl/windows/event_loop.rs?ignore_comments=false