fix: loadMoreBox 노출 조건 수정 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
salmontaker
requested review from
5unk3n,
JangHyunjeong,
salmontaker,
SeungrokYoon and
wisdomin121
SeungrokYoon
approved these changes
Sep 1, 2023
anyl92
force-pushed
the
fix-#41-loadmorebox
branch
from
640f51d
to
625aea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
이슈 리스트 무한스크롤을 위한 loadMoreBox 가 에러컴포넌트 노출 시에도 함께 노출되어
예상하지 않은 무한스크롤 발생 버그
Changes
loadMoreBox 컴포넌트 노출 조건에 (!isErorr) 추가하여 옵저버 동작하지 않도록 했습니다