Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #9 Header에 owner, repo 출력 #35

Closed
wants to merge 2 commits into from
Closed

feat: #9 Header에 owner, repo 출력 #35

wants to merge 2 commits into from

Conversation

SeungrokYoon
Copy link
Contributor

@SeungrokYoon SeungrokYoon commented Sep 1, 2023 •
edited
Loading

Description

Summary

  • 이제 새로운 조직과 레포를 검색하면 리스트가 갱신됩니다.
  • 그에따라 헤더 문구도 변경됩니다.

P.S.

  • 코드가 아름답지는 않습니다만, 기능구현에 초점을 맞춰 구현하였으니 너른 양해 부탁드립니다...ㅠㅠ

newfeature

@SeungrokYoon SeungrokYoon added the feat 기능관련 label Sep 1, 2023
@SeungrokYoon SeungrokYoon self-assigned this Sep 1, 2023
@SeungrokYoon SeungrokYoon linked an issue Sep 1, 2023 that may be closed by this pull request
헤더 컴포넌트 #9
Closed
1 task
@anyl92
Copy link
Member

anyl92 commented Sep 1, 2023

승록님 상탯값 추가 해서 바꿔봤는데 확인 한 번 부탁드려요!

@salmontaker salmontaker changed the title feat: Header에 owner, repo 출력 feat: #9 Header에 owner, repo 출력 Sep 1, 2023
@vercel
Copy link

vercel bot commented Sep 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pre-onboarding-12th-2-7 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:43am

@SeungrokYoon SeungrokYoon marked this pull request as ready for review September 1, 2023 09:09
wisdomin121
wisdomin121 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@wisdomin121 wisdomin121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~!!
facebook/react만 볼 수 있는 게 아니고 다른 repo도 볼 수 있어서 좋은 것 같아요 !

@SeungrokYoon SeungrokYoon deleted the feat/9-header branch September 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisdomin121 wisdomin121 wisdomin121 approved these changes

Assignees

@SeungrokYoon SeungrokYoon

Labels
feat 기능관련
Projects
Week2 - 깃허브 이슈 프로젝트
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

헤더 컴포넌트
3 participants
@SeungrokYoon @anyl92 @wisdomin121