-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor, restructure routes, conform to (zod) openapi spec #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromzeh
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
priority: high
Issue needs to be fixed ASAP
db
r2
dependencies
breaking change
labels
Nov 17, 2023
fuck it, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
db
dependencies
documentation
Improvements or additions to documentation
enhancement
New feature or request
priority: high
Issue needs to be fixed ASAP
r2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr moves all functions into file-based routing and utilizes hono's
zod-openapi
eg
/routes/game/get/id/[id]/route.ts
,openapi.ts
&schema.ts
instead of prev/routes/game/get-game-by-id.ts
(and so it matches the zod-openapi spec)
also utilizes class managers to prevent repetitive code - last minute backend rewrites ftw :3
closes #60