chore(weave): feedback payload 1024 -> 1024*1024 #3023
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f9feb9813c5fd13920c978a7eb2098c41e8b6b74 |
There was a problem hiding this comment.
Could you take a look at #2926 and my comment on that - we should see what values this size do to the UI and we should update the docs.
| @@ -228,7 +228,7 @@ def test_feedback_payload(client): | |||
| def test_feedback_create_too_large(client): | |||
| project_id = client._project_id() | |||
|
|
|||
| value = "a" * 10000 | |||
| value = "a" * 1024 * 1024 | |||
There was a problem hiding this comment.
I am surprised this passes since the size check is for a value > than this (not >=) but InvalidRequest still gets raised?
There was a problem hiding this comment.
thats a great point. 🤔 I will take a peek at why, as well as come up with some testing apparatus in a local trace server to iron out any slow points / loading states needed in the feedback grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per @shawnlewis 's request, bump limit on payload to basically maxed.