chore(weave): Cleanup save object basic #3015
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtruong
commented
Nov 19, 2024
| @@ -1335,13 +1335,13 @@ def _save_object_basic( | |||
| """Directly saves an object to the weave server and attach | |||
| the ref to the object. This is the lowest level object saving logic. | |||
| """ | |||
| orig_val = val | |||
There was a problem hiding this comment.
moved to top for clarity
andrewtruong
commented
Nov 19, 2024
Comment on lines
+1366
to
+1367
| # `to_json` is mostly fast, except for CustomWeaveTypes | ||
| # which incur network costs to serialize the payload |
There was a problem hiding this comment.
moved comment closer to code for clarity
andrewtruong
commented
Nov 19, 2024
| digest_future: Future[str] = self.future_executor.then( | ||
| [res_future], lambda res: res[0].digest | ||
| ) | ||
|
|
||
| ref: Ref | ||
| if is_opdef: | ||
| if is_op(orig_val): |
andrewtruong
commented
Nov 19, 2024
| ref = OpRef(self.entity, self.project, name, digest_future) | ||
| else: | ||
| ref = ObjectRef(self.entity, self.project, name, digest_future) | ||
|
|
||
| # Attach the ref to the object | ||
| try: | ||
| set_ref(orig_val, ref) | ||
| except: | ||
| except Exception: |
There was a problem hiding this comment.
blank except is actually BaseException which is not safe
https://stackoverflow.com/questions/27995057/why-is-it-recommended-to-derive-from-exception-instead-of-baseexception-class-in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidying this block