feat(eslint-config-custom): add new eslint chai plugins and move to d…

…eps from devdeps

apps/lit-override/.eslintrc.cjs

@@ -1,7 +1,6 @@
 module.exports = {
   root: true,
   extends: ['custom/ts.cjs', 'custom/lit.cjs'],
-  plugins: ['lit'],
   ignorePatterns: ['dist/**'],
   parserOptions: {
     ecmaVersion: 'latest',

configs/eslint-config-custom/chai.cjs

@@ -0,0 +1,8 @@
+module.exports = {
+  plugins: ['chai-expect', 'chai-friendly'],
+  extends: ['plugin:chai-expect/recommended', 'plugin:chai-friendly/recommended'],
+  rules: {
+    '@typescript-eslint/no-unsafe-call': 'off',
+    '@typescript-eslint/no-unused-expressions': 'off',
+  },
+};

configs/eslint-config-custom/lit.cjs

@@ -1,4 +1,4 @@
 module.exports = {
-  extends: ['plugin:wc/recommended', 'plugin:lit/recommended'],
-  plugins: ['lit'],
+  plugins: ['lit', 'lit-a11y'],
+  extends: ['plugin:wc/recommended', 'plugin:lit/recommended', 'plugin:lit-a11y/recommended'],
 };

configs/eslint-config-custom/package.json

@@ -11,21 +11,24 @@
     "@typescript-eslint/parser": "6.21.0",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-airbnb-typescript": "17.1.0",
+    "eslint-plugin-chai-expect": "3.0.0",
+    "eslint-plugin-chai-friendly": "0.7.4",
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-jest": "27.9.0",
     "eslint-plugin-jest-dom": "5.2.0",
     "eslint-plugin-jest-formatting": "3.1.0",
+    "eslint-plugin-lit": "1.12.0",
+    "eslint-plugin-lit-a11y": "1.1.0-next.1",
     "eslint-plugin-mdx": "3.1.5",
     "eslint-plugin-react": "7.34.1",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-react-refresh": "0.4.6",
-    "eslint-plugin-storybook": "0.8.0"
+    "eslint-plugin-storybook": "0.8.0",
+    "eslint-plugin-vitest": "0.5.4",
+    "eslint-plugin-wc": "2.1.0"
   },
   "devDependencies": {
-    "eslint": "8.57.0",
-    "eslint-plugin-lit": "1.11.0",
-    "eslint-plugin-vitest": "0.4.0",
-    "eslint-plugin-wc": "2.0.4"
+    "eslint": "8.57.0"
   },
   "peerDependencies": {
     "eslint": "8.57.0"

packages/lit-override/.eslintrc.cjs

@@ -1,7 +1,6 @@
 module.exports = {
   root: true,
-  extends: ['custom/ts.cjs', 'custom/jest.cjs', 'custom/lit.cjs'],
-  plugins: ['lit'],
+  extends: ['custom/ts.cjs', 'custom/jest.cjs', 'custom/lit.cjs', 'custom/chai.cjs'],
   ignorePatterns: ['dist/**', 'coverage'],
   parserOptions: {
     ecmaVersion: 'latest',

packages/lit-override/src/components/lit-override-component.spec.ts

@@ -59,7 +59,6 @@ describe('lit-override', () => {
     const adoptedStyles = el.shadowRoot?.adoptedStyleSheets;
     expect(adoptedStyles?.length).to.equal(1);
     expect(el.innerHTML).to.not.contain('<style></style>');
-    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     expect(el.shadowRoot?.querySelector('style')).to.not.exist;
   });
 
@@ -70,7 +69,6 @@ describe('lit-override', () => {
     el.onConnectedCallback = callbackSpy;
     el.connectedCallback();
     await aTimeout(50);
-    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     expect(callbackSpy).to.have.been.calledOnce;
   });
 
@@ -80,15 +78,13 @@ describe('lit-override', () => {
     el.addEventListener('connected-callback', eventSpy);
     setTimeout(() => el.connectedCallback());
     await aTimeout(50);
-    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     expect(eventSpy).not.to.have.been.called;
   });
 
   it('emits connected-callback event when emitConnectedCallback is true', async () => {
     const el = await fixture<LitOverride>(html`<lit-override emitConnectedCallback></lit-override>`);
     setTimeout(() => el.connectedCallback());
     const ev = await oneEvent(el, 'connected-callback', true);
-    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     expect(ev).to.exist;
   });
 });