Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 8.2 #1285

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Upgrade to Gradle 8.2 #1285

merged 4 commits into from
Jul 4, 2023

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Jul 3, 2023 •
edited
Loading

  • Resolve Upgrade to Gradle 8.2 #1284
  • Use concise syntax for lazy property assignment
  • Work around Spotless conflict with Gradle configuration cache
  • Avoid using task extensions at task execution time

@liblit
Upgrade to Gradle 8.2
4ec77cf 
Resolves wala#1284.
@liblit
Use concise syntax for lazy property assignment
f3617cf 
Gradle 8.2's Kotlin DSL now offers [a more concise syntax for setting
the values of lazy
properties](https://docs.gradle.org/current/userguide/kotlin_dsl.html#kotdsl:assignment).
This feature is still incubatng, but is now enabled by default.  Let's
put it to use!
@liblit liblit added gradle WALA’s Gradle build system dependencies Pull requests that update a dependency file labels Jul 3, 2023
@liblit liblit requested a review from msridhar July 3, 2023 23:42
@liblit liblit self-assigned this Jul 3, 2023
@liblit liblit changed the title Gradle 8.2 Upgrade to Gradle 8.2 Jul 3, 2023
@liblit
Work around Spotless conflict with Gradle configuration cache
2ad60f6 
This Spotless bug workaround replicates the one we were already added to
the top-level `build.gradle.kts` in revision
89de874.
@liblit
Avoid using task extensions at task execution time
caf0c73 
Apparently the Gradle configuration cache does not permit accessing
task extensions at task execution time.  Instead, use task input
properties to store little bits of information that (1) influence a
task's own behavior and also (2) are needed in order to configure
*other* tasks' behaviors.
msridhar
msridhar approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the configuration cache related fixes will address #1278. I can test after this lands

@liblit liblit marked this pull request as ready for review July 4, 2023 00:28
@liblit liblit merged commit 248dbe2 into wala:master Jul 4, 2023
6 checks passed
@liblit liblit deleted the Gradle-8.2 branch July 4, 2023 00:28
@liblit liblit mentioned this pull request Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees

@liblit liblit

Labels
dependencies Pull requests that update a dependency file gradle WALA’s Gradle build system
Projects
Use Gradle configuration cache
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Gradle 8.2
2 participants
@liblit @msridhar