-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes/improvements #72
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, first two changes lgtm.
But not sure I see value in adding some of the other changes. inject_traffic.sh
and run_compose.sh
are just wrappers. More scripts, more code, more possible things to fail and missconfigure. Kind of goes against the principle of keep it simple. The less moving parts the better. Note that this applies to waku-simulator
repo, but if you find this useful for testing, it seems like a great tool. But unsure if we should add it to the repo. Let me know if I'm missing something.
The two scripts have proven quite useful to me, it allows me to run simulations more quickly when Ineed to change parameters. I figured that since they're useful to me it might prove useful to somebody else, hence posting them here. If you think they make the repo more complex I can just pull them away, of course. Last one, the commented out |
a6aa0fd
to
676fb1f
Compare
676fb1f
to
d5ff7ec
Compare
:Z
flag to fix volume sharing on some OSs/dev
volume sharing to fix disk sharing on some OSsinject_traffic.sh
script, which allows to easily change the traffic injection parameters.run_compose.sh
script, which allows to easily change the simulation parameters.