Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes/improvements #72

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Various fixes/improvements #72

wants to merge 7 commits into from

Conversation

AlejandroCabeza
Copy link
Collaborator

  • Add :Z flag to fix volume sharing on some OSs
  • Add /dev volume sharing to fix disk sharing on some OSs
  • Implement the inject_traffic.sh script, which allows to easily change the traffic injection parameters.
  • Implement the run_compose.sh script, which allows to easily change the simulation parameters.

@AlejandroCabeza AlejandroCabeza changed the title Variou fixes/improvements Various fixes/improvements Jun 19, 2024
@alrevuelta alrevuelta self-requested a review June 19, 2024 15:07
Copy link
Collaborator

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, first two changes lgtm.

But not sure I see value in adding some of the other changes. inject_traffic.sh and run_compose.sh are just wrappers. More scripts, more code, more possible things to fail and missconfigure. Kind of goes against the principle of keep it simple. The less moving parts the better. Note that this applies to waku-simulator repo, but if you find this useful for testing, it seems like a great tool. But unsure if we should add it to the repo. Let me know if I'm missing something.

@AlejandroCabeza
Copy link
Collaborator Author

Thanks, first two changes lgtm.

But not sure I see value in adding some of the other changes. inject_traffic.sh and run_compose.sh are just wrappers. More scripts, more code, more possible things to fail and missconfigure. Kind of goes against the principle of keep it simple. The less moving parts the better. Note that this applies to waku-simulator repo, but if you find this useful for testing, it seems like a great tool. But unsure if we should add it to the repo. Let me know if I'm missing something.

The two scripts have proven quite useful to me, it allows me to run simulations more quickly when Ineed to change parameters. I figured that since they're useful to me it might prove useful to somebody else, hence posting them here. If you think they make the repo more complex I can just pull them away, of course.

Last one, the commented out INDEX line, was part of the fix to make podman work. It's not much, but it felt a bit wrong to just throw it away; probably because it was a bit of a pain to arrive there so I didn't want anybody else to go through it 😆. Having said so, I understand it's not complete and if supporting podman is not in the plans, we can just get rid of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants