Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: waku_archive add protection against queries longer than 24h #3256

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR to limit to 24h the max time ranges in store queries.

Issue

closes #3170

Copy link

github-actions bot commented Jan 26, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3256

Built from 67c3fb8

@Ivansete-status Ivansete-status marked this pull request as ready for review January 26, 2025 22:54
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful! Thanks so much!

Copy link
Contributor

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Ivansete-status Ivansete-status merged commit a4d7171 into master Jan 27, 2025
11 of 12 checks passed
@Ivansete-status Ivansete-status deleted the cap-max-time-range-query branch January 27, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: cap max time range allowed in store query
3 participants