feat: waku store sync 2.0 storage and tests #3215
Conversation
SionoiS
requested review from
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
SionoiS
changed the title
|
You can find the image built from this PR at Built from 16f8759 |
Yes, I will add some. |
| method insert*( | ||
| self: SyncStorage, element: ID | ||
| ): Result[void, string] {.base, gcsafe, raises: [].} = | ||
| discard |
There was a problem hiding this comment.
Maybe insert should be idempotent?
There was a problem hiding this comment.
I really like the "idempotent" word but, what does it mean in this context ;P ?
There was a problem hiding this comment.
Currently, when inserting with the same element the first call would be ok() but if you call again err() since the element was already present.
An idempotent function would always insert the same element at the same index and would result in no side effect when calling the same func with the same element multiple times.
| method insert*( | ||
| self: SyncStorage, element: ID | ||
| ): Result[void, string] {.base, gcsafe, raises: [].} = | ||
| discard |
There was a problem hiding this comment.
I really like the "idempotent" word but, what does it mean in this context ;P ?
SionoiS
force-pushed
the
feat--store-sync-storage
branch
from
395a23f to
afde3cf
Compare
Description
Second PR for new Waku store sync 2.0
Include everything Storage related and tests
Specification
Research issue
Changes
N.B. Cannot be merged before #3213
Followed by #3216
Issue