chore: test peer connection management

[Ivansete-status]

Description

Enhance reconnect logic and fix reconnect tests.
The important point is that it is necessary to set a port different than zero in tests.

Changes

Issue

closes

• bug: Peer Reconnection not working? #2592

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3049

Built from 6289957

[gabrielmer]

Looks amazing! Thanks so much!

Added a small question :)

[gabrielmer]

Not sure I understand why this is true. Shouldn't they be theoretically equal, but in practice any of them be longer than the other one?

Or in other words, why reconnectDuration + backoffPeriod.seconds.float can't be greater than reconnectDurationWithBackoffPeriod?

[Ivansete-status]

Not sure I understand why this is true. Shouldn't they be theoretically equal, but in practice any of them be longer than the other one?

Or in other words, why reconnectDuration + backoffPeriod.seconds.float can't be greater than reconnectDurationWithBackoffPeriod?

Actually, in both cases we are doing the same operation but, in when the backoff time assigned is != 0, then we add this extra block:

    if backoffTime > ZeroDuration:
      debug "Backing off before reconnect",
        peerId = peerInfo.peerId, backoffTime = backoffTime
      # We disconnected recently and still need to wait for a backoff period before connecting
      await sleepAsync(backoffTime)

... where we are adding an extra backoffTime plus the time spent in the debug call plus the if statement. Hence, the > condition should happen.