fix: static linking negentropy in ARM based mac #3046
Conversation
gabrielmer
requested review from
richard-ramos,
darshankabariya and
Ivansete-status
|
You can find the image built from this PR at Built from 41bf14c |
Makefile
Outdated
| @@ -185,7 +185,7 @@ $(LIBNEGENTROPY_FILE): | |||
| negentropy: | $(LIBNEGENTROPY_FILE) | |||
| ## Pass libnegentropy and it's deps to linker. | |||
| $(eval LIBNEGENTROPY_PATH := $(shell if [ -f "$(LIBNEGENTROPY_FILE)" ]; then echo "$(LIBNEGENTROPY_FILE)"; else echo "./$(LIBNEGENTROPY_FILE)"; fi)) | |||
| $(eval NIM_PARAMS += --passL:$(LIBNEGENTROPY_PATH) --passL:-lcrypto --passL:-lssl --passL:-lstdc++) | |||
| $(eval NIM_PARAMS += --passL:$(LIBNEGENTROPY_PATH) --passL:-lcrypto --passL:-lssl --passL:-lstdc++ --passL:-L/opt/homebrew/lib/) | |||
There was a problem hiding this comment.
I think we could be a bit more explicit and use detected_OS to give one value or another
There was a problem hiding this comment.
I think we could be a bit more explicit and use
detected_OSto give one value or another
I actually asked @NagyZoltanPeter about it and told me it doesn't hurt and no need to add an if condition for it. I have no specific preference, can do any of both ways :))
There was a problem hiding this comment.
Well this is opted from the negentropy Makefile we had, homebrew is really just a linker hint, doing nothing harm on linux as there are no libs on such path.
There was a problem hiding this comment.
Well this is opted from the negentropy Makefile we had, homebrew is really just a linker hint, doing nothing harm on linux as there are no libs on such path.
ah yes you are right that it doesn't cause any harm but I think is better to be explicit ( or nitpick hehe ;P )
Description
Adding
--passL:-L/opt/homebrew/lib/when linking negentropy to fix error of missing crypto library in ARM based mac