chore: lightpush - error metric less variable by only setting a fixed string #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 3fb859e |
SionoiS
approved these changes
Sep 5, 2024
jakubgs
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid having a too-variable metric by preventing adding the msg_hash on it. In that case, we are just adding a fixed string, not_published_to_any_peer, when the condition "Lightpush request has not been published to any peers" is met.
Thanks for the detailed description @jakubgs 🙌
Issue
bug: absurdly high cardinality of waku_lightpush_errors metrics
closes #3019