chore: libwaku - exposing discv5 store-client and relay connected and mesh peers #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to start or store discv5 - Expose lightpush request operation - Expose list of connected and mesh peers - Expose store client
Ivansete-status
changed the title
|
You can find the image built from this PR at Built from c808660 |
Ivansete-status
requested review from
gabrielmer,
NagyZoltanPeter,
SionoiS and
darshankabariya
gabrielmer
approved these changes
Aug 28, 2024
SionoiS
approved these changes
Aug 29, 2024
Comment on lines
+454
to
+455
| if isNil(callback): | ||
| return RET_MISSING_CALLBACK |
There was a problem hiding this comment.
Why is this needed here but not in all other procs?
There was a problem hiding this comment.
Why is this needed here but not in all other procs?
Good point! Because some checks are left. I will submit an enhancement in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Step further to make nwaku completely accessible from libwaku. Still pending to expose some features such as peer exchange, or filter.
Changes