chore: deprecating pubsub topic config #2779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from a4b768b |
|
You can find the image built from this PR at Built from a4b768b |
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
gabrielmer
added
the
release-notes
gabrielmer
force-pushed
the
chore-deprecating-named-sharding
branch
from
5d93874
to
65cb4f5
Compare
gabrielmer
force-pushed
the
chore-deprecating-pubsub-topic-config
branch
from
79c89fc
to
d6385d6
Compare
gabrielmer
force-pushed
the
chore-deprecating-named-sharding
branch
from
65cb4f5
to
32675a8
Compare
gabrielmer
force-pushed
the
chore-deprecating-pubsub-topic-config
branch
from
d6385d6
to
2e3dd36
Compare
gabrielmer
force-pushed
the
chore-deprecating-named-sharding
branch
from
32675a8
to
519a119
Compare
gabrielmer
force-pushed
the
chore-deprecating-named-sharding
branch
from
61c7815
to
4565042
Compare
10 tasks
gabrielmer
added
E:1.2: Autosharding for autoscaling
|
Closing this PR as it will be replaced by #2997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating the
pubsub-topicCLI config in favor ofcluster-id,shardsand a new config itemnetwork-shardsstating the amount of shards in the givencluster-idfor autosharding purposesRenamed the CLI config
ProtectedTopictoProtectedShard. The idea is to avoid ambiguity so the user only has to be familiar with the termsclusterandshard.The word
pubsubTopicin our codebase will refer solely to the string representation ofclusterId+shardthat we use in thelibp2player.