Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln_keystore_generator): wired to onchain group manager #1931

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 23, 2023

Description

Hooks up the rln_keystore_generator to the OnchainGroupManager.

Changes

  • Integrates OnchainGroupManager
  • Allows broadcasting transactions
  • Writes to keystore appropriately

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1931

@rymnc rymnc self-assigned this Aug 23, 2023
@rymnc rymnc marked this pull request as ready for review August 23, 2023 07:26
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor style comment

Makefile Outdated
@@ -186,7 +186,7 @@ chat2: | build deps librln

rln_keystore_generator: | build deps librln
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for rln-keystore-generator. General Makefile convention is that words in target names are not separated at all or separated by a hyphen. See https://style-guides.readthedocs.io/en/latest/makefile.html#targets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 1870f98

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


# 5. register on-chain
try:
waitFor groupManager.register(credential)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solving this is not related to this PR but if we have a tool to register a membership in nwaku perhaps we should fix this status-im/nim-web3#79 ? May take some time though.

I don't think you are able to broadcast a tx without a chaindId so this groupManager.register will most likely fail unless your Ethereum node uses rpc.allow-unprotected-txs, and afaik thats disabled in most of the cases. So someone using this tool will most likely run into this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice catch! will try to make some time to fix that!

@rymnc rymnc merged commit c9b48ea into master Aug 23, 2023
13 checks passed
@rymnc rymnc deleted the rln-credential-tool-3 branch August 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants