fix: improve node bootstrapping #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
adklempner
approved these changes
Sep 2, 2024
weboko
commented
Sep 2, 2024
| @@ -7,19 +7,13 @@ import { | |||
| } from "@waku/discovery"; | |||
| import { type Libp2pComponents, PubsubTopic } from "@waku/interfaces"; | |||
|
|
|||
| const DEFAULT_NODE_REQUIREMENTS = { | |||
There was a problem hiding this comment.
this one is not needed as there is another on in the dns_discovery/const
weboko
commented
Sep 2, 2024
| @@ -15,7 +15,7 @@ export const DEFAULT_BOOTSTRAP_TAG_VALUE = 50; | |||
| export const DEFAULT_BOOTSTRAP_TAG_TTL = 100_000_000; | |||
|
|
|||
| export const DEFAULT_NODE_REQUIREMENTS: Partial<NodeCapabilityCount> = { | |||
| store: 2, | |||
There was a problem hiding this comment.
matches RFC and decreases changes of hitting bad DNS node (tho it shouldn't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
js-wakunode is bootstrapped with default setting AND broken bootstrap node is used it fails sometimes.And in that case application using
js-wakuhas bad experience.As explained in this comment:
The problem occurs when dns discovery gets us a broken bootstrap node is attempted to be used.
Solution
Increase amount of bootstrap nodes used and at the same time respect our good defaults: 2 filter and light push + 1 store nodes.
Improve dialing as when it fails for bootstrap nodes we should try using others.
Notes