feat: create default shard info, update tests #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weboko
commented
Jul 24, 2024
| @@ -228,6 +228,7 @@ export function contentTopicsByPubsubTopic( | |||
| */ | |||
| export function determinePubsubTopic( | |||
| contentTopic: string, | |||
| // TODO: make it accept ShardInfo | |||
There was a problem hiding this comment.
To follow up: #2086
size-limit report 📦
|
weboko
changed the title
danisharora099
approved these changes
Jul 25, 2024
| * | ||
| * You cannot add or remove pubsub topics after initialization of the node. | ||
| */ | ||
| pubsubTopics?: PubsubTopic[]; |
There was a problem hiding this comment.
I'd vote to remove this completely as well. We are assuming that developers might still want to use named sharding, but a complete deprecation looks like the right step ahead.
There was a problem hiding this comment.
I was also thinking the same - but I changed my mind when recalled scenarios of some of our consumers that do not use any of our fleets, not to mention TWN.
So we need to continue providing support for pubsubTopics in order to allow them soft transition (or for some not to use our fleets at all).
Comment on lines
+141
to
+149
| if (!options.shardInfo) { | ||
| options.shardInfo = DefaultShardInfo; | ||
| } | ||
|
|
||
| const shardInfo = options.shardInfo | ||
| ? ensureShardingConfigured(options.shardInfo) | ||
| : undefined; | ||
|
|
||
| options.pubsubTopics = shardInfo?.pubsubTopics ?? | ||
| options.pubsubTopics ?? [DefaultPubsubTopic]; | ||
| options.pubsubTopics = options.pubsubTopics ?? shardInfo?.pubsubTopics; |
There was a problem hiding this comment.
Here in case shardInfo exists, we have redundancy updating shardInfo as well as pubsubTopic with same information. Comment above about complete deprecation of this property looks like the clean direction.
There was a problem hiding this comment.
This is a good point but I don't think we should get rid of pubsubTopics for internal use because we:
- have tight coupling to it in our code base;
- libp2p itself uses it a lot;
- it's native to gossipSub so anyway we face the need to refer to it one way or another;
weboko
added a commit
that referenced
this pull request
Jul 25, 2024
…2083) * changing default pubsub topic to its static sharding version * keeping RFC's Waku Message test vectors * reverting change in changelog * setting pubsub topic when creating nwaku node * adding shardInfo to runMultipleNodes call * adding shardInfo to runMultipleNodes call in lightpush tests * add pubsub topics to nwaku.start * get rid of it.only that remained * fixing compliance tests * setting clusterId to 0 * removing unnecessary fix * adding shardInfo when creating nodes * fixing wait for remote peer tests * fixing peer exchange test * refactor * removing unnecessary variable * feat: create default shard info, update tests (#2085) * feat: create default shard info, update tests * add link * fix tests * remoe only * up tests * up test --------- Co-authored-by: Sasha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Named sharding is deprecated.
We need to comply
Solution
pubsubTopicparameter as a fallback for consumers of the library that do not use The Waku Network or static sharding;DefaultShardInfoas a fallback that is configured for The Waku Network all shards;DefaultPubsubTopic;Notes