Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove relay from sdk package #2040

Merged
merged 5 commits into from
Aug 31, 2024
Merged

chore: remove relay from sdk package #2040

merged 5 commits into from
Aug 31, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jun 18, 2024

Problem

sdk package has extra dependencies

Solution

remove them and remove unused full node creator function.

Notes

@weboko weboko requested a review from a team as a code owner June 18, 2024 23:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 82.82 KB (-4.84% 🔽) 1.7 s (-4.84% 🔽) 2.9 s (-27.13% 🔽) 4.5 s
Waku Simple Light Node 134.7 KB (-13% 🔽) 2.7 s (-13% 🔽) 3.6 s (-22.03% 🔽) 6.3 s
ECIES encryption 22.94 KB (0%) 459 ms (0%) 975 ms (+53.96% 🔺) 1.5 s
Symmetric encryption 22.39 KB (0%) 448 ms (0%) 1.2 s (+52.76% 🔺) 1.6 s
DNS discovery 72.38 KB (0%) 1.5 s (0%) 2.8 s (+27.5% 🔺) 4.3 s
Peer Exchange discovery 73.73 KB (0%) 1.5 s (0%) 3.3 s (+49.66% 🔺) 4.8 s
Local Peer Cache Discovery 67.63 KB (0%) 1.4 s (0%) 2 s (-24.83% 🔽) 3.3 s
Privacy preserving protocols 74.8 KB (+91.95% 🔺) 1.5 s (+91.95% 🔺) 2.6 s (+87.38% 🔺) 4 s
Waku Filter 78.02 KB (-4.11% 🔽) 1.6 s (-4.11% 🔽) 2.3 s (-26.19% 🔽) 3.9 s
Waku LightPush 75.58 KB (-3.85% 🔽) 1.6 s (-3.85% 🔽) 1.9 s (-46.53% 🔽) 3.4 s
History retrieval protocols 75.96 KB (-4.04% 🔽) 1.6 s (-4.04% 🔽) 3.6 s (+22.22% 🔺) 5.1 s
Deterministic Message Hashing 7.38 KB (0%) 148 ms (0%) 271 ms (-69.36% 🔽) 418 ms

danisharora099
danisharora099 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests that are to be resolved before merge. LGTM

@weboko
Copy link
Collaborator Author

weboko commented Jul 17, 2024

Blocked for now by - https://discord.com/channels/1110799176264056863/1262855908661137449/1262855910985044108
If won't be unblocked - will remove the check as mitigation

weboko
weboko commented Aug 31, 2024
View reviewed changes
packages/tests/tests/store/utils.ts
}

await instance.waitForLog(waku.libp2p.peerId.toString(), 100);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST endpoint does not recognize js-waku as a peer so that is the way we can verify if nwaku has connection, not 100% reliably tho but good enough for us

fyi @fbarbu15 @waku-org/js-waku-developers @NagyZoltanPeter

@weboko weboko merged commit 5cfe932 into master Aug 31, 2024
11 of 12 checks passed
@weboko weboko deleted the weboko/chore-relay branch August 31, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

@adklempner adklempner adklempner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: encapsulate relay in separate package
3 participants
@weboko @adklempner @danisharora099