fix: check for lightclient only if req doesn't contain shards #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
chaitanyaprem
force-pushed
the
fix/metadata-identify-wait
branch
from
078203d
to
6c07039
Compare
chaitanyaprem
changed the title
chaitanyaprem
force-pushed
the
fix/metadata-identify-wait
branch
2 times, most recently
from
4d6b878
to
c77e61f
Compare
… shards are not present
chaitanyaprem
force-pushed
the
fix/metadata-identify-wait
branch
from
c77e61f
to
20f6df4
Compare
richard-ramos
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to take care of intermittent failures in CI as in https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Ftests/detail/PR-5474/23/tests.
Consider chekcing for lightClient only if metadata request doesn't have shards filled in.
Changes
Tests