Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: metadata is not always checking shards for relay peer connectivity #1156

Open
chaitanyaprem opened this issue Jul 10, 2024 · 1 comment

Comments

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented Jul 10, 2024

Describe the bug
after this change , metadata sometimes is considering relay peer as lightclient, probably because identify did not happen till that time.
Hence only clusterID check is done in this case.

This is ok for status since as of now community specific sharding is not implemented and all nodes support all shards. But, this needs to be fixed once sharding for communities is to be implemented.

Similarly for lightClients, shardInfo should be updated in metadata based on filter subscriptions or during init time - TBD

Expected behavior
relay peers should always be verified of matching shards after connecting.

@chaitanyaprem
Copy link
Collaborator Author

Similarly for lightClients, shardInfo should be updated in metadata based on filter subscriptions or during init time - TBD

this may not be required for current community sharding because all fleet nodes support all shards and every user would have to support shards 32 and 64(common shards) which are anyways indicated for lightclient during init. So, metadata should not disconnect any peers.

similarly this change is not required in current milestones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant