-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update shard info config for js-waku #193
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const shardInfo = { clusterId: 3, shard: 1 }; | ||
|
||
// Create Filter subscription with custom shard info | ||
const subscription = await node.filter.createSubscription(shardInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up that it will change soon as the current API seems to be too hard to understand. Maybe we can delay this PR or we can follow up on it. I think we will have it updated in a week or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments about making the code snippets look less chat focussed
Co-authored-by: Sasha <[email protected]>
@@ -24,6 +24,19 @@ await node.start(); | |||
When the `defaultBootstrap` parameter is set to `true`, your node will be bootstrapped using the [default bootstrap method](/guides/js-waku/configure-discovery#default-bootstrap-method). Have a look at the [Bootstrap Nodes and Discover Peers](/guides/js-waku/configure-discovery) guide to learn more methods to bootstrap nodes. | |||
::: | |||
|
|||
A node needs to know how to route messages. In order to do that you can use standard pubsub topic (`/waku/2/default-waku/proto`). If your project uses a different shared pubsub topic, you can configure this using the `ShardInfo` parameter or by using a set of `contentTopics` that your node will be using: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to be done right now: heads up that we will soon change the default pubusb topic to the The Waku Network, pending RLN as a Service for Light Clients is merged on nwaku side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: nwaku has merged this feature and will be released this week. js-waku will followup
cc @weboko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the new pubusb topic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going to be The Waku Network by default -- we are yet to start a PR for it though.
7f4ac16
to
5af7525
Compare
Resolves issue #131
Preview: https://docs-waku-org-git-shard-info-js-waku-acidinfo.vercel.app/guides/js-waku/light-send-receive